Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal all Instance traits #1346

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Seal all Instance traits #1346

merged 2 commits into from
Mar 26, 2024

Conversation

jessebraham
Copy link
Member

While the various Instance traits must be public for the sake of visibility, we should not allow users to implement these traits on arbitrary types. As such, I have sealed as Instance traits.

(Does this require a CHANGELOG.md entry? I don't think so?)

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Mar 25, 2024
@jessebraham jessebraham requested review from bjoernQ and MabezDev March 25, 2024 18:45
MabezDev
MabezDev approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a change log entry (technically breaking, although I seriously doubt anyone implemented those traits themselves), LGTM

bjoernQ
bjoernQ approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - wasn't aware it wasn't before

@jessebraham jessebraham removed the skip-changelog No changelog modification needed label Mar 26, 2024
@jessebraham jessebraham enabled auto-merge March 26, 2024 03:05
@jessebraham jessebraham added this pull request to the merge queue Mar 26, 2024
Merged via the queue into esp-rs:main with commit 7792d67 Mar 26, 2024
21 checks passed
@jessebraham jessebraham deleted the fixes/sealed-instances branch March 26, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @bjoernQ @MabezDev